Only support public post-types/taxonomies for template support #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
approved these changes
Oct 25, 2019
westonruter
deleted the
fix/1786-only-support-public-taxonomies-for-templates
branch
|
Build for testing: amp.zip (v1.4.0-beta1-20191025T144425Z-a116db49) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the way templates are queried for custom post types and custom taxonomies to check for AMP support.
Instead of querying for
publicly_queryable, we query forpublicinstead.Additionally, we add a
_doing_it_wrong()for the case where we end up with a template that is matching but that references a parent template that is not matching or does not exist.Fixes #1786
Checklist